Adds support for sorting locale file keys in pre-commit #8806
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for care-ohc ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Deploying care-fe with
|
| Latest commit: |
5d9f6f6
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://244bc482.care-fe.pages.dev |
| Branch Preview URL: | https://rithviknishad-feat-pre-commi.care-fe.pages.dev |
khavinshankar
approved these changes
Oct 16, 2024
CARE
|
||||||||||||||||||||||||
| Project |
CARE
|
| Run status |
|
| Run duration | 03m 21s |
| Commit |
|
| Committer | Rithvik Nishad |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
0
|
Pending
|
0
|
Skipped
|
0
|
Passing
|
125
|
|
@rithviknishad Your efforts have helped advance digital healthcare and TeleICU systems. 🚀 Thank you for taking the time out to make CARE better. We hope you continue to innovate and contribute; your impact is immense! 🙌 |
bodhish
reviewed
Oct 16, 2024
| fs.readdir(directory, (err, files) => { | ||
| if (err) throw err; | ||
|
|
||
| files.forEach((file) => { |
There was a problem hiding this comment.
For performance we could have chosen just to do it for EN; others would be auto managed by crowdin; just a thought
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
@ohcnetwork/care-fe-code-reviewers